Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/manifest requests #2850

Merged
merged 2 commits into from Aug 26, 2019
Merged

Fix/manifest requests #2850

merged 2 commits into from Aug 26, 2019

Conversation

antross
Copy link
Member

@antross antross commented Aug 22, 2019

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@antross
Fix: Avoid redundant 'fetch::end::manifest' events
2e96a8f 
Moves check for duplicate requests earlier to the fetch phase.
Previously this was handled at the parse phase which was too late
to prevent the associated fetch events from being dispatched.

- - - - - - - - - -

Ref webhintio#2832
@antross
Fix: Ignore 'fetch::end' events generated by manual fetches
5a413cc 
Also use response data from the devtools panel to ensure all response
headers are included.

- - - - - - - - - -

Fix webhintio#2832
Close webhintio#2850
@antross antross merged commit 1cbd205 into webhintio:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarvaje sarvaje sarvaje approved these changes

@molant molant Awaiting requested review from molant molant is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antross @sarvaje