Add rule to check if the lang attribute is used on html element
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrra
commented
Mar 17, 2017
| report: sinon.spy() | ||
| }; | ||
|
|
||
| const window = await getDOM(path.join(__dirname, 'fixtures', filePath)); |
There was a problem hiding this comment.
@molant IMHO, having the fixtures right next to the test file is better.
There was a problem hiding this comment.
That's what I was thinking yesterday while doing some tests. I'll refactor the other ones today.
| @@ -74,7 +74,7 @@ export class RuleContext { | |||
| this.id, | |||
| this.severity, | |||
| descriptor, | |||
| location, | |||
There was a problem hiding this comment.
This was a leftover from when the "find element" related refactoring was done.
alrra
commented
Mar 17, 2017
|
|
||
| import { Rule, RuleBuilder, ElementFoundEvent } from '../../../../lib/types'; // eslint-disable-line no-unused-vars | ||
|
|
||
| const getDOM = async (filePath) => { |
There was a problem hiding this comment.
@molant This will probably go into a separate file as it will be needed in a few places.
qzhou1607-zz
referenced
this pull request
in qzhou1607-zz/Sonar-private
May 17, 2017
* Add index page in each folder according to #45 * A PR will be submitted in sonarwhal to process the index pages
qzhou1607-zz
referenced
this pull request
in qzhou1607-zz/Sonar-private
May 17, 2017
* Add index page in each folder according to #45 * Another PR is submitted in sonarwhal to process the index pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule Details
This rule warns against not using the
langattribute on thehtmlelement, or using it on thehtmlelement but with the value of empty string.It's indicated to always set the
langattribute on thehtmlelement so that it's inherited by all other elements (even the ones in the<head>), and it sets the primary language of the document.Setting the
langattribute provides an explicit indicate to user agents about the language of the content, which can help, among other:screen readers and similar assistive technologies with voice output and pronunciation of content using the correct voice/language library
determine the appropriate language dictionary, the types of quotation marks for
qelements, the styling such as the one for hyphenation, case conversion, line-breaking, and spell-checkingfont selection where different alphabets are mixed
improve localization (e.g. what numeric software keyboard will be opened for
<input type="number">)Resources
Note: This rule does not check if the value of the
langattribute is valid or not (that will be covered by a different rule).Close #16