Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum node version to 14 #5742

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Update minimum node version to 14 #5742

merged 1 commit into from
Mar 15, 2024

Conversation

fliiiix
Copy link
Contributor

@fliiiix fliiiix commented Mar 4, 2024

Seems like this was a bit outdated hint does not run on node 12

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'hint@7.1.10',
npm WARN EBADENGINE   required: { node: '>=14.0.0' },
npm WARN EBADENGINE   current: { node: 'v12.22.9', npm: '8.5.1' }
npm WARN EBADENGINE }

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

Seems like this was a bit outdated hint does not run on node 12

```
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'hint@7.1.10',
npm WARN EBADENGINE   required: { node: '>=14.0.0' },
npm WARN EBADENGINE   current: { node: 'v12.22.9', npm: '8.5.1' }
npm WARN EBADENGINE }
```
Copy link

linux-foundation-easycla bot commented Mar 4, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Member

@vidorteg vidorteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@vidorteg vidorteg merged commit da59800 into webhintio:main Mar 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants