Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: all variables must be camel case - strict #42

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Feature: all variables must be camel case - strict #42

merged 5 commits into from
Oct 25, 2019

Commits on Oct 21, 2019

  1. Feature: all variables must be camel case - strict 

    Defined variables, variables used in strings and class properties must
be now camelCased (strict) - so two capital letters next to each other
are not allowed

Disable `PSR2.Classes.PropertyDeclaration.Underscore` as it is now covered
in `Webimpress\NamingConventions\ValidVariableName` sniff.
    @michalbundyra
    michalbundyra committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    1367876 View commit details
    Browse the repository at this point in the history

  2. CS fixes - update variable names to strict camelCase

    @michalbundyra
    michalbundyra committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6ca5e76 View commit details
    Browse the repository at this point in the history

  3. Rename method name to be also strict camelCase 

    Method names are validated by PSR-2 sniff which doesn't require strict
camelCase names. There is no any option to change it to strict as well.
    @michalbundyra
    michalbundyra committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    b37706d View commit details
    Browse the repository at this point in the history

  4. Updated test - string without variables inside 

    It should increase coverage
    @michalbundyra
    michalbundyra committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    873292e View commit details
    Browse the repository at this point in the history

  5. Remove redundant condition and use coalesce op instead

    @michalbundyra
    michalbundyra committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    f8afacf View commit details
    Browse the repository at this point in the history