Feature: property type declaration support (PHP 7.4+) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 7.4 we can declare property type. Add support for property types in the following sniff: - `Commenting\PropertyAnnotation` - ensure that type is skipped when detecting the comment before property - `Commenting\VariableComment` - add multiple checks to ensure type declaration is consistent with type provided in PHPDoc (`@var` tag). In case type declaration is provided and PHPDoc does not contain any additional information, `@var` tag can be omitted.
Description might not be set and preg_split result will just have one value if there is comment closing tag after the tag content
On fixing we add the description back only when it was set. It could be an empty string, so we need then add just a space - so we have one space before closing comment tag.
michalbundyra
added a commit
that referenced
this pull request
Nov 13, 2019
Feature: property type declaration support (PHP 7.4+)
michalbundyra
added a commit
that referenced
this pull request
Nov 13, 2019
michalbundyra
added a commit
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 7.4 we can declare property type.
Add support for property types in the following sniff:
Commenting\PropertyAnnotation- ensure that type is skipped when detecting the comment before propertyCommenting\VariableComment- add multiple checks to ensure type declaration is consistent with type provided in PHPDoc (@vartag).In case type declaration is provided and PHPDoc does not contain any additional information,
@vartag can be omitted.