Do not ask for the same package if it is already prepared to be insta…

…lled

src/Plugin.php

@@ -134,6 +134,11 @@ private function andDependencies(array $extra)
         $packages = array_flip($deps);
 
         foreach ($packages as $package => &$constraint) {
+            if ($this->isPackageReadyToInstall($package)) {
+                unset($packages[$package]);
+                continue;
+            }
+
             if ($this->hasPackage($package)) {
                 unset($packages[$package]);
                 continue;
@@ -169,6 +174,11 @@ private function orDependencies(array $extra)
             }
 
             foreach ($options as $package) {
+                if ($this->isPackageReadyToInstall($package)) {
+                    // Package has been already prepared to be installed, skipping.
+                    continue 2;
+                }
+
                 if ($this->hasPackage($package)) {
                     // Package from this group has been found in root composer, skipping.
                     continue 2;
@@ -319,10 +329,25 @@ private function createInstaller(Composer $composer, IOInterface $io, RootPackag
 
     private function hasPackage($package)
     {
+        $lower = strtolower($package);
+
         $rootPackage = $this->composer->getPackage();
         $requires = $rootPackage->getRequires() + $rootPackage->getDevRequires();
         foreach ($requires as $name => $link) {
-            if (strtolower($name) === strtolower($package)) {
+            if (strtolower($name) === $lower) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    private function isPackageReadyToInstall($package)
+    {
+        $lower = strtolower($package);
+
+        foreach ($this->packagesToInstall as $name => $version) {
+            if (strtolower($name) === $lower) {
                 return true;
             }
         }

test/PluginTest.php

@@ -607,6 +607,36 @@ public function testUpdateComposerWithCurrentlyInstalledVersion($operation)
         $this->assertPackagesToInstall(['extra-dependency-foo' => '^0.5.1']);
     }
 
+    /**
+     * @dataProvider operation
+     *
+     * @param string $operation
+     */
+    public function testDoNotInstallAskTwiceForTheSamePackage($operation)
+    {
+        $this->injectPackages([
+            'extra-package' => '^1.0.1',
+        ]);
+
+        $event = $this->getPackageEvent('some/component', [
+            'dependency' => [
+                'extra-package',
+            ],
+        ], $operation);
+
+        $this->composer->getPackage()->shouldNotBeCalled();
+
+        $this->io->isInteractive()->willReturn(true);
+        $this->io
+            ->askAndValidate(Argument::any(), Argument::type('callable'))
+            ->shouldNotBeCalled();
+
+        $this->assertNull($this->plugin->onPostPackage($event));
+        $this->assertPackagesToInstall([
+            'extra-package' => '^1.0.1',
+        ]);
+    }
+
     /**
      * @dataProvider operation
      *
@@ -881,6 +911,45 @@ public function testIntegrationHandleDependencyAndDependencyOr($operation)
         ]);
     }
 
+    /**
+     * @dataProvider operation
+     *
+     * @param string $operation
+     */
+    public function testIntegrationDoNotAskWhenAlreadyChosen($operation)
+    {
+        $event = $this->getPackageEvent('some/component', [
+            'dependency' => [
+                'extra-package-required',
+            ],
+            'dependency-or' => [
+                'Choose something' => [
+                    'extra-choose-one',
+                    'extra-choose-two',
+                    'extra-choose-three',
+                    'extra-package-required',
+                ],
+            ],
+        ], $operation);
+
+        $this->setUpRootPackage();
+
+        $this->io->isInteractive()->willReturn(true);
+        $this->io
+            ->askAndValidate(
+                'Enter the version of <info>extra-package-required</info> to require'
+                . ' (or leave blank to use the latest version): ',
+                Argument::type('callable')
+            )
+            ->willReturn('1.8.3')
+            ->shouldBeCalledTimes(1);
+
+        $this->assertNull($this->plugin->onPostPackage($event));
+        $this->assertPackagesToInstall([
+            'extra-package-required' => '1.8.3',
+        ]);
+    }
+
     private function assertSetRequiresArgument($name, $version, array $arguments)
     {
         if (! isset($arguments[$name])) {