Added tests for HTML and redirect returns #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierCuyp
requested changes
Mar 14, 2020
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "test:lint": "semistandard --verbose | snazzy", | |||
| "test:cover": "nyc --reporter=text-summary --reporter=html npm test", | |||
| "test:coveralls": "nyc --reporter=text-lcov npm test | coveralls", | |||
| "test:all": "npm run test:lint" | |||
| "test:all": "npm run test:lint && npm run test && npm run test:cover && npm run test:coveralls" | |||
There was a problem hiding this comment.
Here it should be:
"test:all": "npm run test:lint && npm run test:cover"Since test:cover already run npm test and test:coveralls is meant only for the CI to publish on coveralls
OlivierCuyp
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.