feat(koji): add koji #384
feat(koji): add koji #384
Conversation
|
Hey, just wanted to let you know that I appreciate this and I'll be taking a look at it within the next week or so. I just spent a bunch of time on Webi PRs and updates a few weeks ago and I've needed to focus on some other projects for a bit to get caught up on them. :) |
There was a problem hiding this comment.
This looks really awesome! It's up on beta at https://beta.webinstall.dev/koji
I bet @wmerfalen will love it (and we'll probably start using it at work).
That said, I have a few requests before merging this in. Mostly because webinstall.dev is meant for idiots like me and the docs aren't quite complete enough for me to know how I'm supposed to use this.
I'd love to get this into prod in the next day or two if you'd just make the couple of requested updates.
:)
|
P.S. Would you like to join us in remote for a lightning talk in February at Utah Rust? Someone there may be able to help with Windows support. |
|
@coolaj86 heyo, will get to this tonight! i plan on adding windows support at some point, mostly comes down to not knowing how to have github actions build for windows yet but its on my todo list. |
|
@coolaj86 I think all is well, fleshed out README and ran prettier & shfmt. |
koji/README.md
Outdated
| cd dev/work-stuff | ||
| # Do some work | ||
| cd dev/work-stuff | ||
| git add .env.production |
There was a problem hiding this comment.
umm... no... DO NOT commit private keys for prod!!!
There was a problem hiding this comment.
joke from repo README lol, probably shoulda changed it
|
Now that I understand this better and I've had a chance to try it out, I've updated the README in a way that I feel is more targeted towards our audience. |
|
Live at https://webinstall.dev/koji/ I don't have it on the homepage yet, but I think it needs a little work before it's ready for prime time. :) |
Not a clue what the requirements are for getting a package added, but would be nice to get my little conventional commit util in here if possible. No windows support atm, so no installer for it.
The project for reference: https://github.com/its-danny/koji