fix: replace all occurrences, not just the first one

webiny · Oct 8, 2021 · 1f6e1b0 · 1f6e1b0
1 parent 618a393
commit 1f6e1b0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/cli-plugin-scaffold-graphql-api/src/index.ts b/packages/cli-plugin-scaffold-graphql-api/src/index.ts
@@ -174,7 +174,7 @@ export default (): CliCommandScaffoldTemplate<Input> => ({
                                 path.join(context.project.root, input.path, "code", "graphql"),
                                 context.project.root
                             )
-                            .replace("\\", "/")
+                            .replace(/\\/g, "/")
                     }
                 ];
                 replaceInPath(p, replacements);
@@ -191,7 +191,7 @@ export default (): CliCommandScaffoldTemplate<Input> => ({
                                 path.join(context.project.root, input.path, "code", "graphql"),
                                 context.project.root
                             )
-                            .replace("\\", "/")
+                            .replace(/\\/g, "/")
                     }
                 ];
                 replaceInPath(p, replacements);
@@ -221,7 +221,7 @@ export default (): CliCommandScaffoldTemplate<Input> => ({
 
             // Add package to workspaces.
             const rootPackageJsonPath = path.join(context.project.root, "package.json");
-            const pathToAdd = `${input.path}/code/graphql`.replace("\\", "/");
+            const pathToAdd = `${input.path}/code/graphql`.replace(/\\/g, "/");
             await addWorkspaceToRootPackageJson(rootPackageJsonPath, pathToAdd);
 
             ora.stopAndPersist({

diff --git a/packages/cli-plugin-scaffold-react-app/src/index.ts b/packages/cli-plugin-scaffold-react-app/src/index.ts
@@ -174,7 +174,7 @@ export default (): CliCommandScaffoldTemplate<Input> => ({
 
             // Add package to workspaces.
             const rootPackageJsonPath = path.join(context.project.root, "package.json");
-            const pathToAdd = `${input.path}/code`.replace("\\", "/");
+            const pathToAdd = `${input.path}/code`.replace(/\\/g, "/");
             await addWorkspaceToRootPackageJson(rootPackageJsonPath, pathToAdd);
 
             ora.stopAndPersist({

diff --git a/packages/cli-plugin-scaffold/src/utils/addWorkspaceToRootPackageJson.ts b/packages/cli-plugin-scaffold/src/utils/addWorkspaceToRootPackageJson.ts
@@ -5,7 +5,7 @@ import { PackageJson } from "@webiny/cli-plugin-scaffold/types";
 
 export default async (packageJsonPath, pathToAdd) => {
     // Ensure forward slashes are used.
-    pathToAdd = pathToAdd.replace("\\", "/");
+    pathToAdd = pathToAdd.replace(/\\/g, "/");
 
     const rootPackageJson = await readJson<PackageJson>(packageJsonPath);
     if (!rootPackageJson.workspaces.packages.includes(pathToAdd)) {