fix: correct behavior of plugins retrieval functions (#1316)

webiny · Oct 24, 2020 · 2291eab · 2291eab
1 parent b76bb03
commit 2291eab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/plugins/src/PluginsContainer.ts b/packages/plugins/src/PluginsContainer.ts
@@ -45,14 +45,14 @@ export class PluginsContainer {
         return this.plugins[name] as T;
     }
 
-    byType<T extends Plugin>(type?: string): T[] {
-        if (!type) {
-            return Object.values(this.plugins) as T[];
-        }
-
+    byType<T extends Plugin>(type: string): T[] {
         return Object.values(this.plugins).filter((pl: Plugin) => pl.type === type) as T[];
     }
 
+    all<T extends Plugin>(): T[] {
+        return Object.values(this.plugins) as T[];
+    }
+
     register(...args: any): void {
         const [plugins, options] = normalizeArgs(args);
         assign(plugins, options, this.plugins);

diff --git a/packages/plugins/src/index.ts b/packages/plugins/src/index.ts
@@ -8,6 +8,9 @@ const registerPlugins = (...args: any): void => {
 };
 
 const getPlugins = <T extends Plugin = Plugin>(type?: string) => {
+    if (!type) {
+        return plugins.all<T>();
+    }
     return plugins.byType<T>(type);
 };