fix(migrations): filter batches after promise is resolved

webiny · Apr 30, 2024 · 90f428f · 90f428f
1 parent 4753668
commit 90f428f
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/packages/migrations/src/migrations/5.40.0/001/ddb/index.ts b/packages/migrations/src/migrations/5.40.0/001/ddb/index.ts
@@ -100,31 +100,33 @@ export class PbUniqueBlockElementIds_5_40_0_001 implements DataMigration {
                         );
 
                         const items = await Promise.all(
-                            blocks
-                                .map(async block => {
-                                    const newContent = await this.generateElementIds(block);
-                                    if (!newContent) {
-                                        return null;
-                                    }
-
-                                    return this.blockEntity.putBatch({
-                                        ...block,
-                                        content: newContent
-                                    });
-                                })
-                                .filter(Boolean) as Promise<BatchWriteItem>[]
+                            blocks.map(async block => {
+                                const newContent = await this.generateElementIds(block);
+                                if (!newContent) {
+                                    return null;
+                                }
+
+                                return this.blockEntity.putBatch({
+                                    ...block,
+                                    content: newContent
+                                });
+                            })
                         );
 
                         const execute = () => {
-                            return batchWriteAll({ table: this.blockEntity.table, items });
+                            return batchWriteAll({
+                                table: this.blockEntity.table,
+                                items: items.filter(Boolean) as BatchWriteItem[]
+                            });
                         };
 
                         await executeWithRetry(execute, {
                             onFailedAttempt: error => {
                                 logger.error(
                                     `"batchWriteAll" attempt #${error.attemptNumber} failed.`
                                 );
-                                logger.error(error.message);
+                                console.log(items);
+                                console.log(error);
                             }
                         });