Skip to content

Commit

Permalink
fix: make element prop optional for BulkAction (#3687)
Browse files Browse the repository at this point in the history
  • Loading branch information
leopuleo committed Nov 10, 2023
1 parent 20e651b commit a78f96a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface BulkActionProps {
remove?: boolean;
before?: string;
after?: string;
element: React.ReactElement;
element?: React.ReactElement;
}

export const BaseBulkAction: React.FC<BulkActionProps> = ({
Expand All @@ -40,7 +40,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
after={placeAfter}
>
<Property id={getId(name, "name")} name={"name"} value={name} />
<Property id={getId(name, "element")} name={"element"} value={element} />
{element ? (
<Property id={getId(name, "element")} name={"element"} value={element} />
) : null}
</Property>
</Property>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface BulkActionProps {
before?: string;
after?: string;
modelIds?: string[];
element: React.ReactElement;
element?: React.ReactElement;
}

export const BaseBulkAction: React.FC<BulkActionProps> = ({
Expand Down Expand Up @@ -47,7 +47,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
after={placeAfter}
>
<Property id={getId(name, "name")} name={"name"} value={name} />
<Property id={getId(name, "element")} name={"element"} value={element} />
{element ? (
<Property id={getId(name, "element")} name={"element"} value={element} />
) : null}
</Property>
</Property>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface BulkActionProps {
remove?: boolean;
before?: string;
after?: string;
element: React.ReactElement;
element?: React.ReactElement;
}

export const BaseBulkAction: React.FC<BulkActionProps> = ({
Expand All @@ -40,7 +40,9 @@ export const BaseBulkAction: React.FC<BulkActionProps> = ({
after={placeAfter}
>
<Property id={getId(name, "name")} name={"name"} value={name} />
<Property id={getId(name, "element")} name={"element"} value={element} />
{element ? (
<Property id={getId(name, "element")} name={"element"} value={element} />
) : null}
</Property>
</Property>
);
Expand Down

0 comments on commit a78f96a

Please sign in to comment.