Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make element prop optional for BulkAction #3687

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: make element prop optional for BulkAction #3687

merged 1 commit into from
Nov 10, 2023

Conversation

leopuleo
Copy link
Contributor

Changes

With this PR, we fix the <BulkAction> configuration property by making the element prop optional and allowing developers to define:

<ContentEntryListConfig>
  <Browser.BulkAction name={"delete"} remove />
</ContentEntryListConfig>

How Has This Been Tested?

Manually

@leopuleo leopuleo added this to the 5.38.0 milestone Nov 10, 2023
@leopuleo leopuleo self-assigned this Nov 10, 2023
Pavel910
Pavel910 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Love small PRs 😂

@Pavel910 Pavel910 merged commit a78f96a into next Nov 10, 2023
63 checks passed
@leopuleo leopuleo deleted the leo/fix/bulk-actions-config branch December 5, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavel910 Pavel910 Pavel910 approved these changes

Assignees

@leopuleo leopuleo

Labels
file-manager Headless CMS page-builder
Projects
None yet
Milestone
5.38.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leopuleo @Pavel910