5.40.0 Fixes - Batch 2 (themes/src)
#4135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arg makes it a bit easier to immediately add initial dependencies (if the user knows them).
May help with ensuring all of the files/folders are ready for yarn.
….40-fixes-batch-1
|
Went through this changes with @Pavel910. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR moves all of the code in the
extensions/themefolder toextensions/theme/src. This was made for consistency (the new scaffolds also follow this folder structure).With that, one additional change we did here is the import of the
global.scssfile. Previously, the file was directly imported from Admin/Website React apps, but now, they are imported within the thethemepackage's code.How Has This Been Tested?
Manually.
Documentation
Changelog.