Improvements on Pulumi-related code #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Along the way, in a real Webiny project, we discovered a couple of issues and improvements that can be made to the infrastructure-related Pulumi code, mainly in the production environment section.
//) in a path of one of the functions.protectedflag to mission-critical resources: DynamoDB and ElasticSearch databases, Cognito user pool, and important S3 buckets. This will protect users from performing theyarn webiny destroycommand in the production environment.How Has This Been Tested?
Manual.
Screenshots (if relevant):