Rerender page from the page builder #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedrzu
changed the title
kedrzu
force-pushed
the
feature/rerender-page
branch
from
e25fcd4
to
45bfb1b
Compare
|
We decided to remove the button in the UI and leave only GQL mutation. This way we basically restrict it from non-technical users, that will not be aware what is the purpose of the button. |
adrians5j
requested changes
Dec 7, 2021
| import { GraphQLSchemaPlugin } from "@webiny/handler-graphql/types"; | ||
| import { Page, PbContext } from "~/types"; | ||
| import Error from "@webiny/error"; | ||
| import resolve from "./utils/resolve"; | ||
| import pageSettings from "./pages/pageSettings"; | ||
| import { fetchEmbed, findProvider } from "./pages/oEmbed"; | ||
| import lodashGet from "lodash/get"; | ||
| import { PageSecurityPermission } from "@webiny/api-page-builder/types"; | ||
| import checkBasePermissions from "@webiny/api-page-builder/graphql/crud/utils/checkBasePermissions"; |
There was a problem hiding this comment.
BTW @kedrzu, check these two imports. Use "~" when importing from package root.
Wouldn't mention this, but CI/CD threw an error related to these two imports. Using "~" will fix it.
There was a problem hiding this comment.
Also, PageSecurityPermission can be added to the import statement in line 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Right now, the only way for users to re-render a page is to create a new revision of it and publish it again, which is pretty annoying. This adds a feature of re-rendering the page from the page preview:
Also there is a new dedicated mutation
pageBuilder.rerenderPagethat you can use in your own scripts.How Has This Been Tested?
Manual tests of the new
rerenderPagemutation and admin app.