feat: add unique validator to headless cms #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #1939
Be careful when using DynamoDB only project and this validator as it loads all the records in given model and then checks for the uniqueness.
If a value is not passed to the
uniquevalidator, nothing happens. If users want some value to be present in theuniquefield, they must set therequiredvalidator on that field.How Has This Been Tested?
Jest and manually.
Documentation
Added note in the changelog: https://deploy-preview-375--webiny-docs.netlify.app/docs/release-notes/5.22.0/changelog#added-unique-validator-for-cms-model-field-2166
Upgrade
Need to write an upgrade to add unique validator to user project
apps/admin/code/src/plugins/headlessCMS.ts.