Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Apollo Client for All GraphQL API Operations #3020

Merged
merged 1 commit into from Feb 16, 2023

Conversation

adrians5j
Copy link
Member

Changes

With this PR, we're no longer relying on default data loaders for Form and Pages List page elements. We're using our own, which are powered by the existing Apollo client.

This will ensure the tenant/locale headers are always included upon issuing GQL operations.

How Has This Been Tested?

Manual.

Documentation

Changelog.

@adrians5j adrians5j added this to the 5.34.4 milestone Feb 16, 2023
@adrians5j adrians5j self-assigned this Feb 16, 2023
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfectly ok to me, this isn't the first time we're using component factories, so I don't see any problems with this. Thanks for a quick fix, I'll be using this today!

@adrians5j adrians5j merged commit 898bece into dev Feb 16, 2023
@adrians5j adrians5j deleted the 5344-tenants-locales-headears branch June 5, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants