Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folder creation in root #3328

Merged
merged 3 commits into from May 25, 2023
Merged

fix: folder creation in root #3328

merged 3 commits into from May 25, 2023

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented May 24, 2023

Changes

With this PR we fix a bug introduced by the 5.36.0 version: creating a folder in the root using the "Create folder" button in the top right corner. After completing the folder creation process, this was not saved with the right parentId.

How Has This Been Tested?

Manually

@leopuleo leopuleo added this to the 5.36.1 milestone May 24, 2023
@leopuleo leopuleo requested a review from brunozoric May 24, 2023 15:13
@leopuleo leopuleo self-assigned this May 24, 2023
@leopuleo leopuleo marked this pull request as ready for review May 24, 2023 15:14
@brunozoric
Copy link
Contributor

@leopuleo
This will fix the future creation of the folders. For the existing ones to be listed you must add the root check in this method:
https://github.com/webiny/webiny-js/blob/fix/folder-in-root-creation/packages/app-aco/src/hooks/useAcoList.ts#L49

@leopuleo leopuleo merged commit 3f2551f into dev May 25, 2023
59 checks passed
@leopuleo leopuleo deleted the fix/folder-in-root-creation branch June 5, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants