Various Minor Fixes (Page Builder and webiny info CLI Command)
#3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
webiny info CLI Command)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses one CLI issue and a couple of PB-related issues.
1.
webiny infoCommand Not WorkingFor some time, the
webiny infocommand would not work if an environment wasn't specified (in which case the command should internally get a list of all environments user currently has locally set up). This has now been addressed.2. Button Page Element Crashing On Empty Link URL
In some cases, a
nullvalue would end up being passed to the Button page element's Link component, which would cause an error being thrown. With this PR, falsy values have been taken into consideration, in which case href will be set simply to an empty string.3. Website Settings - Theme Selector Not Working Properly
In a multi-theme setup, in the website settings form, at the end of the form, the select component that would enable users to pick a theme for the current tenant wasn't working as expected. On page load, the select component would be empty, which is not good DX (ideally the select component should show the selected value).
Since this is a bug in the Select component, which we've seen before, as a quick fix, we've just replaced it with an Autocomplete component. This might even work better in cases users has more themes set up in his project.
4. Intermittent Errors When Refreshing the Page Builder
Intermittently, the page builder would break upon refreshing the page. Essentially, this happened because of the async nature of the way the theme is loaded. This would only happen in multi-theme projects.
This has now been addressed.
How Has This Been Tested?
Manual.
Documentation
Changelog.