Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FolderTree performance #3332

Merged
merged 3 commits into from May 25, 2023
Merged

fix: FolderTree performance #3332

merged 3 commits into from May 25, 2023

Conversation

leopuleo
Copy link
Contributor

Changes

This PR:

  • optimize sorting function within FolderTree component using useMemo
  • solves a performance issue within FolderTree component generated by 8+ nested folders (now tested up to 50)
  • increases to 10.000 the listFolders limit, instead of the default provided by cms.listLatestEntries

How Has This Been Tested?

Manually

@leopuleo leopuleo added the aco label May 24, 2023
@leopuleo leopuleo added this to the 5.36.1 milestone May 24, 2023
@leopuleo leopuleo requested a review from brunozoric May 24, 2023 19:55
@leopuleo leopuleo merged commit 420ad8e into dev May 25, 2023
59 checks passed
@leopuleo leopuleo deleted the fix/folder-tree-performance branch June 5, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunozoric brunozoric brunozoric approved these changes

Assignees
No one assigned
Labels
aco
Projects
None yet
Milestone
5.36.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leopuleo @brunozoric