Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-headless-cms): permissions checks #3449

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

brunozoric
Copy link
Contributor

Changes

The main part of this PR is the export of access checks for models and groups. Adrian removed those when he introduced new security stuff.

PR also includes:

  • attach permissions to the CmsContext so they are available to the public
  • remove unnecessary locale parameter from model and group permission checks as it already exists on both group and model
  • group permission check params now require only a small part of the group object to be sent into it
  • model permission check params now require only a small part of the model object to be sent into it

How Has This Been Tested?

Jest and manually.

@brunozoric brunozoric self-assigned this Jul 27, 2023
@brunozoric brunozoric added this to the 5.37.1 milestone Jul 27, 2023
adrians5j
adrians5j previously approved these changes Jul 27, 2023
Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brunozoric brunozoric changed the base branch from next to dev July 27, 2023 10:34
@brunozoric brunozoric dismissed adrians5j’s stale review July 27, 2023 10:34

The base branch was changed.

@brunozoric brunozoric marked this pull request as ready for review July 27, 2023 10:35
@brunozoric brunozoric merged commit 26cace7 into dev Jul 27, 2023
58 checks passed
@brunozoric brunozoric deleted the bruno/fix/api-headless-cms/permissions-checks branch September 12, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants