Migrations/ES Index Creation: Double Check If the ES Index Exists #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've seen a case where the
esCreateIndexutility function throws theresource_already_exists_exceptionerror, despite the fact the internal index existence check told us that the index does not exist.Because of this, upon index creation, if an error is throw, we double check the error message and if it's again mentioned
resource_already_exists_exception, we just return the index name and we don't consider this as an actual error.How Has This Been Tested?
Did a quick test with a local script mimicking the same index creation logic. Ensured the
ex.messageis actually the error code we're expecting.Documentation
Changelog.