Sanitize HTML in @webiny/react-rich-text-renderer package #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihajlovco
added
work-in-progress (wip)
Co-authored-by: Sasho Mihajlov <sashomihajlov@Sashos-MacBook-Pro.local> Co-authored-by: adrians5j <adrian@webiny.com>
added 5 commits
August 18, 2023 13:59
mihajlovco
changed the title
mihajlovco
removed
the
work-in-progress (wip)
Pavel910
changed the title
Pavel910
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we want to sanitize the
Editor.jscontent from the Headless CMS, to prevent the possibility of the XSS attack, since the default editor.js behavior allows you to write unescaped HTML in the editor, and have it executed in the browser.Changes
configureSanitization, which allows developers to fine-tune the sanitization behaviorRichTextRenderercomponent also supports sanitization config via props, which can be used to fine-tune individual instances of the component, on top of the global configurationHow Has This Been Tested?
Manually.