fix(api-elasticsearch): contains query with slash #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavel910
approved these changes
Sep 13, 2023
|
/cypress |
|
Cypress E2E tests have been initiated (for more information, click here). ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using the contains query, which contained slash (/) in the search term, Elasticsearch failed with a parsing error because of wrong slash escaping in the built query.
Example:
article w/ authorwould produce:
*article w\\\\/ author*but it should have produced:
*article w\\\/ author*Also, when w/ is at the start or the end of the search term, it would produce a parsing error.
For those two cases, the asterisk (*) is not prepended or appended to the search term, depending on the position of the slash:
article w/will produce*article w/w/ articlewill produce/w article*How Has This Been Tested?
Jest.