Headless CMS - "multipleValues" renderer for Date/Time field #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `RemoveFieldButton`
add `dateTimeFields` components for field with multipleValues true
adrians5j
requested changes
Jun 9, 2020
replace `ButtonDefault` with `IconButton`
adrians5j
requested changes
Jun 11, 2020
| import React from "react"; | ||
| import {css} from "emotion"; | ||
| import {Cell} from "@webiny/ui/Grid"; | ||
| import {IconButton} from "@webiny/ui/Button"; |
| <IconButton className={deleteIconStyles} onClick={trailingIcon.onClick} icon={trailingIcon.icon} /> | ||
| </Cell> | ||
| ) | ||
| } |
|
|
||
| const plugin: CmsEditorFieldRendererPlugin = { | ||
| type: "cms-editor-field-renderer", | ||
| name: "cms-editor-field-renderer-date-time", |
There was a problem hiding this comment.
While you're at it, check packages/app-headless-cms/src/admin/plugins/fields/dateTime.tsx:12, this one has dateTime in the name. Ideally we'd use kebab case here.
There was a problem hiding this comment.
Actually, you opened this file in a different branch
| @@ -3,16 +3,25 @@ import { I18NValue } from "@webiny/app-i18n/components"; | |||
| import { CmsEditorField } from "@webiny/app-headless-cms/types"; | |||
| import { BindComponentRenderProp } from "@webiny/form"; | |||
| import { Input as UiInput } from "@webiny/ui/Input"; | |||
| import {ReactNode} from "react"; | |||
adrians5j
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #914
Related Issue
#914
Headless CMS - "multipleValues" renderer for Date/Time field
Your solution
Use
DynamicListMultipleValuescomponentHow Has This Been Tested?
Manually, using the Admin app
Screenshots:
https://www.loom.com/share/ed8b97db76e8426ba86af1aa70e4572f