Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stabilizing Predictions #52

Merged
merged 1 commit into from Dec 25, 2023
Merged

Fix Stabilizing Predictions #52

merged 1 commit into from Dec 25, 2023

Conversation

vmanc
Copy link
Contributor

@vmanc vmanc commented Dec 22, 2023

Pull Request

  • I confirm that I have read the CONTRIBUTING.md document.
  • I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
  • I confirm that I did not use any AI-based coding assistance (such as, but not limited to, GitHub Copilot).

Description

@chschroeder
Copy link
Contributor

Thank you very much for the PR!

A short summary of our e-mail correspondence, so that others can follow:

  • This was part of the same e-mail correspondence as Update Predicted Change in F-Measure #51.
  • The problem here was caused by me trying to fix the underlying problem: cohen's kappa can result in a division by zero when all predictions are of the same class (resulting in a nan value). My solution when I first tackled this issue, however, was not the correct way to handle this, and broke the original functionality.
  • I offered to do the cleanup work (docstrings, changelog, and docs).
  • Also I will add a new section to the docs (likely titled "errata") so that this bug is documented.
  • We agreed that I can move adapted_cohen_kappa() to the outer level so that it could be imported from other places as well.

@chschroeder chschroeder merged commit b9840ab into webis-de:v1.3.x Dec 25, 2023
chschroeder added a commit that referenced this pull request Dec 26, 2023
Signed-off-by: Christopher Schröder <chschroeder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants