-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SCSS files / folder #52
Comments
Which version do you need this for? |
possibly the latest v4 |
Since version 4.0.0-beta, there is no scss folder in the jar: But this issue seems to be about adding it at about that time, which is confusing. Can someone explain? |
Maybe the problem is that bootstrap has started not distributing the scss files in their main -dist.zip download. It's now in a separate "source files" download: http://getbootstrap.com/docs/4.0/getting-started/download/ |
Yeah, the WebJar just packages up whatever we get from the upstream provider. Maybe we need a new bootstrap-scss WebJar? |
@jamesward now bootstrap v4 is officially live, would it be possible to restore the scss folder to allow development with sass? ATM there is no other workaround I can think of beside importing bootstrap's code in my codebase (strongly undesirable). IMHO the outdated bootstrap-scss WebJar seems the wrong place for this scope. I would suggest creating a new WebJar named bootstrap-source which picks the source .zip from their release page. Please let me know if I can help in any way as I need scss and bootstrap v4 to continue on my work. Thanks! Edit: another solution is to use the bower version ("org.webjars.bower" % "bootstrap" % "4.0.0") which imports the whole bootstrap repo. |
@jamesward Would it be possible to add the
scss
folder to the jar? I think that adding it to this line would suffice https://github.com/webjars/bootstrap/blob/master/pom.xml#L114.The text was updated successfully, but these errors were encountered: