Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous version ranges are problematic #1804

Open
vemv opened this issue Aug 21, 2018 · 1 comment
Open

Superfluous version ranges are problematic #1804

vemv opened this issue Aug 21, 2018 · 1 comment
Labels

Comments

@vemv
Copy link

vemv commented Aug 21, 2018

Hi there,

org.webjars.npm/github-com-bevacqua-dragula "3.7.2" depends on org.webjars.npm/contra "[1.9.4,1.9.4]". That range appears quite clearly to be redundant, and possibly useless (unless it's there as a workaround for a reason...)

The problem with ranges is that they break Leiningen's dependency "linter" (its :pedantic? option):

https://github.com/technomancy/leiningen/blob/f8689bbf23dea4c9c4a39975d26ff314cbd5f02f/sample.project.clj#L88

So, at work we normally use :pedantic? :abort, which generally works fine and is greatly useful towads reliable builds. But the notion of ranges (seldom used in the Clojure world) makes :pedantic? :abort abort the build for this seemingly-silly reason.

Any chance to improve the situation?

Thanks - Victor

@jamesward
Copy link
Member

With NPM and Bower WebJars we try our best to replicate the upstream dependency graph. So if the upstream uses ranges, then so do the WebJars. In Classic WebJars we don't use ranges. As far as the weird [1.9.4,1.9.4] range, it is probably worth investigating why that range was produced in the conversion instead of just 1.9.4.

@jamesward jamesward added the bug label Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants