Update admin-site to support json schema #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJFB
approved these changes
Aug 19, 2023
Comment on lines
+17
to
+24
| name={"questions." + index + ".name"} | ||
| placeholder={""} | ||
| label={"Label"} | ||
| /> | ||
| <Field | ||
| name={"questions." + index + ".label"} | ||
| component={TextAreaField} | ||
| placeholder={""} |
There was a problem hiding this comment.
Looks like JsonFieldTextAreas placeholder-field is supposed to be used here 🤔
|
Converted to draft to ensure it is not merged before 2023 admissions, will merge some time after that. |
norbye
added
approved
norbye
force-pushed
the
json-schema-admin
branch
from
d434e2e
to
b0f78c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the main backend changes, see #1178.
Updates the admin-views to support viewing applications, download CSVs and edit the JSON schema.
The backend + the frontend structure supports adding fields, reordering fields, etc. but this is not implemented in the GUI yet. Would rather do this in a later PR.
The functionality to change the top questions (info and phone number in the screenshot in #1179) is not yet implemented, but will match the visual preview for group-leaders.
Visual preview
Admin page for group-leaders and recruiters
Admin page for admission-admins
Resolves ABA-515, ABA-516