Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staging to docker build process #1195

Merged
merged 1 commit into from Aug 7, 2023
Merged

Add staging to docker build process #1195

merged 1 commit into from Aug 7, 2023

Conversation

norbye
Copy link
Member

@norbye norbye commented Aug 5, 2023

Realized this was missing - made it a bit harder to deploy properly

@norbye norbye requested a review from ivarnakken August 5, 2023 05:59
Comment on lines +85 to 86
- staging
- prod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so the plan here is to merge everything into the staging branch first? how agile 😨

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weeell I mostly just want it to be an option..

as I see it the options are either building it in master, or building it in both staging and prod. And with the frequency of the builds of this project it seems unnecessary to build for every push to master (mostly dependabot).
Could of course make a build branch and do the building there - but it seems a bit impractical to merge to main, push to build, push to staging, push to prod and have to wait for the steps to complete for each change.

Leaves the problem that occured in kvittering where dev/staging is miles behind prod and master though, so it might be better to merge everything through master..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough to change at a later time though. For now I think this'll work all right and I'll see if I can think of a more effective way to 1. make sure staging doesn't get lost behind 2. avoid running CI unnecessarily for every new commit to master 3. have staging up and running later

@norbye norbye merged commit 712f05e into master Aug 7, 2023
3 checks passed
@norbye norbye deleted the add-staging-docker branch August 7, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants