Use "gruppe" instead of "komite" in strings in revue admission #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
force-pushed
the
revue-group-not-comitee
branch
from
ba97f66
to
8b44395
Compare
eikhr
requested review from
itsisak,
danielyanghansen,
juniwbjerde,
EliHaugu and
jennymul
norbye
approved these changes
Sep 3, 2023
| <NoChosenSubTitle> | ||
| Send inn en ny søknad for å velge komitéer. | ||
| Send inn en ny søknad for å velge{" "} | ||
| {isRevy ? "grupper" : "komiteer"}. | ||
| </NoChosenSubTitle> | ||
| <LegoButton | ||
| icon="arrow-forward" | ||
| iconPrefix="ios" | ||
| to={`/${admissionSlug}/velg-komiteer`} |
There was a problem hiding this comment.
Could you also change so this path is /velg-grupper?
danielyanghansen
approved these changes
Sep 3, 2023
Update path from /velg-komiteer to /velg-grupper. Add revy email as contact email. Remove logos.
|
Updated with the changes I requested in #1218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of text-strings say "komite" throughout the webapp. This is a quick and easy fix to make it work for the admission on monday by replacing "komite" with "gruppe" if the slug is "revy".
Also removes some text saying only the relevant group can read the application, as I believe the entire revue board can read all applications.