Implement sorting in admin view #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
approved these changes
Sep 3, 2023
| import { | ||
| AlphabeticalComparatorAsc, | ||
| AlphabeticalComparatorDesc, | ||
| ApplicationComparator, |
There was a problem hiding this comment.
I suppose this should be imported as a type but oh well
|
LGTM |
danielyanghansen
approved these changes
Sep 3, 2023
juniwbjerde
approved these changes
Sep 3, 2023
frontend/src/utils/sortAdmissions.ts
Outdated
Comment on lines
17
to
24
| const CreatedAtComparatorAsc: ApplicationComparator = { | ||
| compare: (app1, app2) => { | ||
| const date1 = new Date(app1.created_at); | ||
| const date2 = new Date(app2.created_at); | ||
| return date2.getTime() - date1.getTime(); | ||
| }, | ||
| description: "Dato Opprettet Stigende", | ||
| }; |
There was a problem hiding this comment.
Couldn't this just be the negation of theCreatedAtComparatorDesc? Then we wouldn't have as much duplicated code:) The same goes for all the other ones.
| }, | ||
| description: "Dato Opprettet Stigende", | ||
| }; | ||
|
|
There was a problem hiding this comment.
I also kind of think I would prefer to have the field sorted on and the direction of the sort as separte options. Like having one seletor for what to sort by, and one for the direction of the sort. Just makes more sense to me. But it's not important, it can be changed later on if we want it:)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easily extendable to add more sorts. Looks a little ugly, no CSS because I hate it
Screencast.from.09-03-2023.04.56.12.PM.webm
Resolves: ABA-560