Update admission queryset to be admission-specific #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbye
requested review from
eikhr,
PeterJFB,
danielyanghansen,
juniwbjerde and
a team
norbye
force-pushed
the
permission-fixup
branch
3 times, most recently
from
1a3ec51
to
9a35ccc
Compare
PeterJFB
approved these changes
Sep 5, 2023
Agree, although I have no more time to look at it for the next 8+ hrs, so I won't be able to fix that right now |
norbye
force-pushed
the
permission-fixup
branch
3 times, most recently
from
824a145
to
2b50c60
Compare
norbye
force-pushed
the
permission-fixup
branch
from
2b50c60
to
535426b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the application list not care about is_staff and is_superuser, but rather the memberships in the groups pertaining the the admission.
The code that deletes applications still uses is_staff and is_superuser, but you could copy the same logic in that part if that's important..