Connect admin-pages under the same view #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norbye
added
enhancement
ABA-411 Connect admin-pages
Currently, the adminpage where you see the results of the admission and edit the questions are more "connected" to actually sending your own application (through the navbar). It would be nice to instead make it simpler to navigate between the two admin-views (if allowed). Could possibly be nice to also allow navigating to the admission, but that's not as important imo.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both group admins and admission admins (group leader+recruiting and abakus/revue leader) now use the same admin pages to reduce duplicate code.
The editing of questions for groups has been moved to separate URLs, that only group leader+recruiting has access to.
This fixes the issue we have right now where the leaders of the different groups in the revue do not have access to edit their own texts, because they also have permission to view all applications.
Minor changes
Preview
Application list
Edit group details
No permission to edit group details
Resolves ABA-411