Add cypress as dep and initialize first test #1342
Conversation
norbye
added
enhancement
| image: abakus/lego-testbase:python3.9 | ||
| pull: true | ||
| image: abakus/lego-testbase:poetry | ||
| pull: if-not-exists |
There was a problem hiding this comment.
Any reason this is only added to this step? Just genuinely wondering
There was a problem hiding this comment.
Hmm good question!
The drone docs aren't very clear on what the default value of pull is imo, but the way I understand the docs, we wouldn't really need to use the pull attribute as long as we're not tagging out images with :latest, unless we do not want it to cache.
So the default behavior for non-latest tags appears to be if-not-exists.
But regarding why it's just on this step, I suppose it is because this file was originally copied from lego, and in https://github.com/webkom/lego/blob/master/.drone.yml#L69-L92 the only two steps that have the pull attribute set are black and mypy, and mypy is not implemented in admissions.
pull: true does not appear to be a valid tag however, but if it is processed at all I would guess it reads as pull: always, which would mean unnecessary fetching of docker images that are cached
There was a problem hiding this comment.
Docs for reference: https://docs.drone.io/pipeline/docker/syntax/images/#pulling-images
There was a problem hiding this comment.
Yes I see. I've had mixed experiences with Drone's "cache", so imo. it's fine to leave it.
There was a problem hiding this comment.
Fair enough. Although I guess we might eventually decide on whether or not we type out the configuration or not - as all the steps should now be configured the same way, but black is the only one where it's written out
norbye
added
approved
Setup initial cypress setup and test.
Had some issues running this through drone, will look into that later.
Not much juicy stuff to test right now, but I've got a login bypass ready to enable testing of more functionality that requires authentication - but we'll save that for later too 馃殼
Resolves ABA-414