Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of application form components #1347

Merged
merged 1 commit into from Jan 9, 2024
Merged

Refactoring of application form components #1347

merged 1 commit into from Jan 9, 2024

Conversation

norbye
Copy link
Member

@norbye norbye commented Jan 9, 2024

Did a lil cleanup with the intention of making my next feature-pr a little bit smaller.

No funcitionality should be changed, and as far as I've tested the site still works.

@norbye norbye added enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features review-needed Pull requests that need review labels Jan 9, 2024
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

frontend/src/routes/ApplicationForm/FormContainer.tsx Outdated Show resolved Hide resolved
frontend/src/routes/ApplicationForm/FormContainer.tsx Outdated Show resolved Hide resolved
@norbye norbye added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Jan 9, 2024
@norbye norbye merged commit 7aa8665 into master Jan 9, 2024
3 checks passed
@norbye norbye deleted the form-cleanup branch January 9, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants