Escape quotation mark in application when exporting to csv #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniwbjerde
force-pushed
the
fix-csv-export
branch
from
bafbfef
to
179cd29
Compare
juniwbjerde
changed the title
SmithPeder
requested changes
Nov 3, 2021
There was a problem hiding this comment.
The idea is good.
But maybe make this into a util function, then reuse that function.
export const prepare(text) => text.replaceAll('"', "'")This function could also have a default return like "Empty TextField" or something, so you don't need a big turnery in the setState.
juniwbjerde
force-pushed
the
fix-csv-export
branch
from
ef61dbf
to
263f06f
Compare
LudvigHz
approved these changes
Nov 4, 2021
SmithPeder
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #397
I've changed so that all " in user input texts are replaced with ' when exporting to csv. This solves the problem we had when exporting the csv, since the ' in the application text won't be confused with the " used as the enclosing character for the csv fields (which was the problem before).
PS: Comma is still the separator used in the csv file, but I did not bother to replace all commas with anything, as the problem arises when you have a combination of " and , and it is read as the and of one field and then a seperator and then the start of another. Having just commas in the application texts should not be a problem as long as they're not paired with " (and vise versa, but i figured it would be less of a problem to replace " with ' than to find something to replace all commas with)