Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ESLint, prettier and stylelint #2041

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Bump ESLint, prettier and stylelint #2041

merged 1 commit into from
Nov 9, 2020

Conversation

AdrianAndersen
Copy link
Member

Bump ESLint and conform code to the new linting standards.

Exceptions:

  • Some legacy code: Suppressed with eslint-ignore-next-line.
  • Non-string literal property keys are not supported in flow yet, and thus I had to apply some FlowFixMe in two cases

LudvigHz
LudvigHz approved these changes Nov 7, 2020
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I can't believe that eslint didn't enforce strict equals before 🥉.

@AdrianAndersen AdrianAndersen merged commit ce5d271 into master Nov 9, 2020
@AdrianAndersen AdrianAndersen deleted the bumpESLint branch November 9, 2020 09:06
@odinuge odinuge mentioned this pull request Nov 11, 2020
Merged
@AdrianAndersen AdrianAndersen mentioned this pull request Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@erlingfn erlingfn Awaiting requested review from erlingfn

@ingraso ingraso Awaiting requested review from ingraso

@iselinee iselinee Awaiting requested review from iselinee

@JonasBak JonasBak Awaiting requested review from JonasBak

@SmithPeder SmithPeder Awaiting requested review from SmithPeder

@theodorsm theodorsm Awaiting requested review from theodorsm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AdrianAndersen @LudvigHz