Fix Turnstile theme discrepany #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollfkaih
force-pushed
the
turnstile-theme
branch
from
cfcf292
to
657a33e
Compare
LudvigHz
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
LGTM 馃挴
Yeah, the theme changing is not perfect here, just due to the way we handle the theme stuff. To change the theme dynamically we would ideally store it in redux or a context or something and use that in the component to force a re-render. Since the component won't re-render when we change the theme here.
I am planning on improving the situation, with also storing the theme in localstorage, so unauthed users don't have their theme reset every time they reload the page 馃檭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of minor issues:
Closes webkom/lego#3036