Fix dropdown overflow & add border to reactionpick #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABA-242 Overflow issue on Dropdown and Popover
Now that they have a bigger border-radius, it is more noticeable that its content overflows. E.g., open header dropdown, and hover over the top or bottom row. Because of the caret (arrow at the top), we cannot use overflow: hidden. |
ivarnakken
added
bug-fix
LudvigHz
force-pushed
the
popover-fixes
branch
from
3069ee5
to
8ac1bfa
Compare
ivarnakken
approved these changes
Feb 5, 2023
ivarnakken
removed
review-needed
LudvigHz
force-pushed
the
popover-fixes
branch
from
8ac1bfa
to
2923095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix dropdown overflow.
Add border to reactionpicker popover to get more depth and contrast.
Result
Testing
Resolves ABA-242