Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VisKart button #3524

Merged
merged 1 commit into from Feb 7, 2023
Merged

Improve VisKart button #3524

merged 1 commit into from Feb 7, 2023

Conversation

Arashfa0301
Copy link
Contributor

@Arashfa0301 Arashfa0301 commented Feb 6, 2023

Improved the design and the placement of "Vis kart" button at event pages.


image

image

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 6, 2023
@Arashfa0301 Arashfa0301 added small-fix Pull requests that fix something small approved Pull requests that have been approved labels Feb 6, 2023
@ivarnakken
Copy link
Member

ivarnakken commented Feb 6, 2023

I'm not really a fan of the button being so eye-catching. This draws more attention to the button than the info text, which isn't good, even though the button itself is nice. With the current flat button, it blends in more nicely. Could it be an idea to just make the text itself clickable, and give it some other styling to indicate this?

Also, the logo and text would need more spacing in between.

@LudvigHz
Copy link
Member

LudvigHz commented Feb 6, 2023

I'm not really a fan of the button being so eye-catching

I disagree. The current text is really hidden and not discoverable. The button is eye-catching but that's what we want. People will click on it and know what it's for in other events. It doesn't really matter if their attention is drawn for a bit. The info is there for them to see if they want and choose. And the mazemap logo makes it obvious what kind of map it is.

@ivarnakken ivarnakken removed the approved Pull requests that have been approved label Feb 6, 2023
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I like it! Could make the logo smaller if people find it too much, but I think it's an improvement :)

@Arashfa0301 Arashfa0301 closed this Feb 7, 2023
@Arashfa0301 Arashfa0301 reopened this Feb 7, 2023
@Arashfa0301
Copy link
Contributor Author

Clicked the wrong button 🥲

@Arashfa0301
Copy link
Contributor Author

LGTM

I like it! Could make the logo smaller if people find it too much, but I think it's an improvement :)

The logo looks smaller when the page is not zoomed in. It anyhow can be improved at a later date.

@Arashfa0301 Arashfa0301 merged commit 3df6eb1 into master Feb 7, 2023
@Arashfa0301 Arashfa0301 deleted the improve-showMap-button branch February 7, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
3 participants