Minor iterations multiple places #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They had different paddings and margins, causing the "Påmeldinger" header to be pushed further up than the other headers. Resolves ABA-248
- Icons in the table header did not match the text color - Give delete icon a confirm modal for safety purposes - Delete icon was not centered
- Secondary font color on timestamps (notifications dropdown and article details). - Set default pill color to be the lego font color, since pills used as links turn red. - Icon sizes are reduced in the event items.
Background was overflowing out from the increased border-radius. This was a bit more tricky than for the other header dropdown because of the scroll behaviour.
ivarnakken
added
enhancement
ivarnakken
added
the
chore
ivarnakken
added
approved
ivarnakken
deleted the
ivarnakken/aba-252-iterate-further-on-the-recent-color-and
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Align overview headers correctly
They had different paddings and margins, causing the "Påmeldinger"
header to be pushed further up than the other headers.
Resolves ABA-248
Before
After
Small table iteration
Iterate on the recent font and color changes
details).
links turn red.
Before
After
Stop overflow on notification dropdown
Background was overflowing out from the increased border-radius. This
was a bit more tricky than for the other header dropdown because of
the scroll behaviour.
Before
After
Testing
Tested all changes on light mode, dark mode and on mobile.