Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add admin info about how many unregistered has paid #3532

Merged
merged 1 commit into from Feb 7, 2023
Merged

Add admin info about how many unregistered has paid #3532

merged 1 commit into from Feb 7, 2023

Conversation

jonasdeluna
Copy link
Member

Add admin info about how many unregistered has paid if any, as well as add it to the list of unregistered people.
Hide payment count if 0.

Before:
image

After:
image

image

image

@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 7, 2023
@ivarnakken ivarnakken added the new-feature Pull requests that introduce a new feature label Feb 7, 2023
ivarnakken
ivarnakken approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 Good of you to add a check of whether anyone has actually paid before showing the counters!

@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Feb 7, 2023
@jonasdeluna jonasdeluna merged commit c9ebfed into master Feb 7, 2023
@jonasdeluna jonasdeluna deleted the showallpayments branch February 7, 2023 20:02
@jonasdeluna jonasdeluna mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved new-feature Pull requests that introduce a new feature
Projects
None yet
Milestone
No milestone
2 participants
@jonasdeluna @ivarnakken