Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite CompanyDetail to make it look more like the webapp #3540

Merged
merged 3 commits into from Feb 13, 2023
Merged

Rewrite CompanyDetail to make it look more like the webapp #3540

merged 3 commits into from Feb 13, 2023

Conversation

ingraso
Copy link
Member

@ingraso ingraso commented Feb 9, 2023

Description

The detailed view of a company really needed a retouch. Now it uses the same layouts as events and meetings, with the sidebar and compact information there. Also, the components for joblisting and events (on the user profile) are used, to ensure consistency.

Result

The detailed view with sidebar and main sections separated. The extra compact version of the events, that is also used on the user profile, is used.
Before
Screenshot from 2023-02-09 17-09-16

After
Screenshot from 2023-02-09 17-10-14

The previous events now also use the same layout.
Before
Screenshot from 2023-02-09 17-10-44

After
Screenshot from 2023-02-09 17-10-54

An example of a company without any data.
Before
Screenshot from 2023-02-09 17-13-45

After
Screenshot from 2023-02-09 17-13-40

An example of a company with a long description.
Before
Screenshot from 2023-02-09 17-13-13

After
Screenshot from 2023-02-09 17-12-20

It still does not look particularly good on phones, but in my opinion it looks slightly better than the current view.
Before
Screenshot from 2023-02-09 17-32-50

After
Screenshot from 2023-02-09 17-32-10

Testing

  • I have thoroughly tested my changes.

Tested by clicking around, both in light and dark mode, as well as looked at the design on both smaller and larger screen sizes.

Resolves ABA-263

@ingraso ingraso added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review labels Feb 9, 2023
@ingraso ingraso self-assigned this Feb 9, 2023
@linear
Copy link

linear bot commented Feb 9, 2023

ABA-263 Improve the CompanyDetail page

The CompanyDetail page needs a retouch. In the first place, it should look more like the other pages on the website.

image.png

@ingraso ingraso requested a review from a team February 9, 2023 16:51
@ingraso ingraso added the do-not-merge/WIP Pull requests that are "work in progress", and should not be merged label Feb 9, 2023
@ingraso ingraso force-pushed the aba-263-company-detail-rewrite branch from 5f62565 to 2ccccb3 Compare February 9, 2023 17:00
ivarnakken
ivarnakken approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huuuuuuge improvement! 😍😍 Awesome!!

app/routes/company/components/CompanyDetail.tsx Outdated Show resolved Hide resolved
app/routes/company/components/CompanyDetail.tsx Outdated Show resolved Hide resolved
app/routes/company/components/CompanyDetail.tsx Outdated Show resolved Hide resolved
@ivarnakken ivarnakken added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Feb 9, 2023
@ingraso ingraso force-pushed the aba-263-company-detail-rewrite branch from 2ccccb3 to 3e4832b Compare February 9, 2023 17:47
@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 9, 2023
@falbru
Copy link
Contributor

falbru commented Feb 9, 2023

Looks a lot cleaner now!

@LudvigHz
Copy link
Member

Wow, this is awesome!! 🤩 Sorely needed!!

Only thing I can comment on the design is maybe having a "show more" thing for the company text. I assume for companies like Netcompany with a lot of text you'd need to scroll through a lot of text to see events and joblistings. So the classic "text fade out" with a "Show more" button is probably a good idea :) Could be added later though.

@ingraso
Copy link
Member Author

ingraso commented Feb 10, 2023

Only thing I can comment on the design is maybe having a "show more" thing for the company text. I assume for companies like Netcompany with a lot of text you'd need to scroll through a lot of text to see events and joblistings. So the classic "text fade out" with a "Show more" button is probably a good idea :) Could be added later though.

Agreed! I think that would be great in a later iteration 🚀

@ivarnakken
Copy link
Member

@ingraso, is this still a WIP?

@ivarnakken ivarnakken removed the review-needed Pull requests that need review label Feb 12, 2023
@ivarnakken
Copy link
Member

Btw, it would be nice if the "placeholder text" here had the same styling, but that can be fixed later :shipit:
image

@ingraso
Copy link
Member Author

ingraso commented Feb 13, 2023

@ingraso, is this still a WIP?

@ivarnakken yeah, gonna move the JoblistingList to a separate component or something else to not mix components from other routes as Ludvig commented.

Also, I want to do another iteration on the design etc., so regarding the font style I'll look at that in the next iteration.

@ivarnakken
Copy link
Member

Also, I want to do another iteration on the design etc., so regarding the font style I'll look at that in the next iteration.

That's what I like to hear! 🚀

@ingraso
Create separate component for JoblistingItem
872c33e 
To avoid using the component from a different route, we rather create a
separate component for it. Then this one is used in CompanyDetail and in
JoblistingList.
@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 13, 2023
@ingraso ingraso removed the do-not-merge/WIP Pull requests that are "work in progress", and should not be merged label Feb 13, 2023
LudvigHz
LudvigHz approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarnakken ivarnakken added ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Feb 13, 2023
@ivarnakken ivarnakken merged commit 68d3fcf into master Feb 13, 2023
@ivarnakken ivarnakken deleted the aba-263-company-detail-rewrite branch February 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees

@ingraso ingraso

Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged
Projects
None yet
Milestone
No milestone
4 participants
@ingraso @falbru @LudvigHz @ivarnakken