Only show loading indicator when necesarry #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on /events, you'll get a loading indicator even though you have events stored. This is for obvious reasons unecesarry, and is fixed here.
ivarnakken
added
review-needed
LudvigHz
approved these changes
Feb 10, 2023
|
Thanks, this has annoyed me for a long time 👍 |
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently on /events, you'll get a loading indicator even though you have events stored. This is for obvious reasons unnecessary, and is fixed here.
Result
Before
Screen.Recording.2023-02-10.at.14.06.53.mov
After
Whenever the theme changes, that's me doing a hard refresh. Notice that I do a hard refresh on two different routes.
Screen.Recording.2023-02-10.at.14.04.23.mov
Testing
Navigated between routes and did hard refreshes. This should not affect anything else.
Resolves ABA-267