Improve /companies page #3552
Merged
Improve /companies page #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cards now employ the `<Card />` component, making them resemble the rest of the webapp more. Also some other minimal styling changes. Finally, the whole card is a link, and not just the image, which has been an annoying bug for a really long time. `CompaniesPage` is rewritten to a functional component. `isHoverable` prop is added for cards that work as links.
ivarnakken
added
enhancement
ivarnakken
commented
Feb 11, 2023
Comment on lines
-7
to
-15
|
|
||
| /** Small */ | ||
| tight?: boolean; | ||
|
|
||
| /** Shadow */ | ||
| shadow?: boolean; | ||
|
|
||
| /** Hidden overflow */ | ||
| overflow?: boolean; |
There was a problem hiding this comment.
If you need to comment on the prop name, you've chosen a bad name.
|
I still think we need the option to filter and sort on these companies, but that requires more work and I have an event to attend. |
ingraso
approved these changes
Feb 11, 2023
ivarnakken
added
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cards now employ the
<Card />component, making them resemble the rest of the webapp more. Also some other minimal styling changes. Finally, the whole card is a link, and not just the image, which has been an annoying bug for a really long time.CompaniesPageis rewritten to a functional component.isHoverableprop is added for cards that work as links.Result
Before
Screen.Recording.2023-02-11.at.14.59.52.mov
After
Screen.Recording.2023-02-11.at.14.58.50.mov
Testing
Tested on light and dark mode, and on mobile (some minimal changes here to the expanded text functionality).
Resolves ABA-270