Improve page sidebar layout and design #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiastofte
added
the
enhancement
ivarnakken
approved these changes
Feb 12, 2023
| font-weight: 600; | ||
| width: 95%; | ||
| text-align: center; | ||
| border-bottom: 2px solid var(--additive-background); |
There was a problem hiding this comment.
I feel like the border color should be var(--border-gray) so that it matches the rest of the webapp, but could you maybe instead tweak it to be lighter and better looking? I never changed it up.
|
I've resolved the issues mentioned and I've also improved the mobile view. The mobile view is still a bit ugly, although it's much better than before and it can be improved upon further later.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Since the old branch was so behind I just redid everything from scratch with typescript.
So right now the page sidenav looks hideous on the live webapp. It's one of those components that have long been overlooked and been needing a retouch for a while. In this PR I've improved both the user experience and visual aesthetics for the sidenav. I'm not quite finished yet, I still need to do mobile view improvements, but I would still like to get early feedback so this is the reason I've made this PR.
Result
before
after
Note: The lighter color is the new highlighting color