Standardize our shadows #3556
Merged
Standardize our shadows #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 shadows of proportionally different sizes have been introduced, which all use the same color. I've not added shadows to any new places.
ivarnakken
added
enhancement
eikhr
approved these changes
Feb 12, 2023
eikhr
added
approved
LudvigHz
approved these changes
Feb 13, 2023
ivarnakken
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
4 shadows of proportionally different sizes have been introduced, which all use the same color. I've not added shadows to any new places.
Result
Not really any major visual changes. The shadow on the cards remain the same, so you can check them out.
Testing
Went through all uses of
box-shadow. Since I've not added any new shadows anywhere, this should not affect anything else.