Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart colors #3557

Merged
merged 1 commit into from Feb 12, 2023
Merged

Fix chart colors #3557

merged 1 commit into from Feb 12, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Feb 12, 2023

Description

Chart colors were wrong when some options had no responses. In this example all respondents responded with 4 or 5.
Before:
Screenshot 2023-02-12 at 20 45 44
After:
Screenshot 2023-02-12 at 20 46 11

Result

The charts now show the correct colors even if some options are not included in the graph.

Testing

  • I have thoroughly tested my changes.

I have looked at the graphs, and compared with the individual responses.


@eikhr eikhr requested review from AdrianAndersen and a team February 12, 2023 19:49
@github-actions github-actions bot added the review-needed Pull requests that need review label Feb 12, 2023
@ivarnakken ivarnakken added bug-fix Pull requests that fix a bug approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Feb 12, 2023
@eikhr eikhr merged commit 16b997e into master Feb 12, 2023
@eikhr eikhr deleted the fix-charts branch February 12, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug
Projects
None yet
3 participants